MiniSnippet of the Day - equals NullPointerException

MiniSnippet of the Day - equals

Codesmell:

public boolean isFoo(String parameter) {
	return parameter.equals("foo");
}

Problem: parameter can be null, thus throwing NullPointerException

Corrected:

public boolean isFoo(String parameter) {
	return "foo".equals(parameter);
}

Solution: works also if parameter is null, no extra null-check is required (which could have been forgotten)

Always use a Constant as the object to call equals on, when the second object is variable.

There should be a Checkstyle or PMD rule for that.

• Comments (0)
• Trackbacks (0)